Chromium Code Reviews| Index: components/nacl/renderer/ppb_nacl_private_impl.cc |
| diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc |
| index 354b61cd6a1c691083ab920592dcc07f881b4318..ff46c0e0d22decd4e1d71e4760282d015a243a4b 100644 |
| --- a/components/nacl/renderer/ppb_nacl_private_impl.cc |
| +++ b/components/nacl/renderer/ppb_nacl_private_impl.cc |
| @@ -130,15 +130,10 @@ class NaClPluginInstance { |
| explicit NaClPluginInstance(PP_Instance instance) |
| : nexe_load_manager(instance), pexe_size(0) {} |
| ~NaClPluginInstance() { |
| - // Make sure that we do not leak a file descriptor if the NaCl loader |
| + // Make sure that we do not leak a mojo handle if the NaCl loader |
| // process never called ppapi_start() to initialize PPAPI. |
| - if (instance_info) { |
| -#if defined(OS_WIN) |
| - base::win::ScopedHandle closer(instance_info->channel_handle.pipe.handle); |
| -#else |
| - base::ScopedFD closer(instance_info->channel_handle.socket.fd); |
| -#endif |
| - } |
| + if (instance_info) |
| + instance_info->channel_handle.mojo_handle.Close(); |
|
raymes
2016/10/17 23:28:53
Should we DCHECK that it's a mojo_handle?
Sam McNally
2016/10/18 05:03:51
Done.
|
| } |
| NexeLoadManager nexe_load_manager; |