Use ChannelMojo for plugin-renderer channels.

Use ChannelMojo for plugin-renderer channels.

patch from issue 2168523002 at patchset 20001 (http://crrev.com/2168523002#ps20001)

BUG=604282
COLLABORATOR=amistry@chromium.org

Committed: https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1
Cr-Commit-Position: refs/heads/master@{#425900}

[Sam McNally, 2016-09-02 00:29:18]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 00:29:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 01:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 01:03:29]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Sam McNally, 2016-09-02 02:50:23]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 02:50:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 03:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 03:15:57]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Sam McNally, 2016-09-02 06:06:21]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 06:06:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 06:37:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 06:37:55]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Sam McNally, 2016-09-02 06:47:50]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 06:48:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 08:00:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 08:00:50]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-09-05 07:16:35]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 07:16:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 08:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 08:21:20]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-09-21 07:08:48]

Description was changed from

==========
Use ChannelMojo for plugin-renderer channels.

patch from issue 2168523002 at patchset 20001
(http://crrev.com/2168523002#ps20001)

BUG=604282
==========

to

==========
Use ChannelMojo for plugin-renderer channels.

patch from issue 2168523002 at patchset 20001
(http://crrev.com/2168523002#ps20001)

BUG=604282
COLLABORATOR=amistry@chromium.org
==========

[Sam McNally, 2016-09-21 07:18:51]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 07:19:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-21 07:20:53]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-09-21 07:20:55]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-09-21 07:20:59]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-09-21 07:21:00]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-09-21 07:21:02]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-09-21 07:21:16]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 07:21:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-21 07:34:45]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 07:34:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-21 07:34:59]

Patchset #2 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-09-21 08:30:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 08:30:17]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-10-12 03:49:17]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 03:49:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 05:09:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 05:09:35]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-10-17 22:51:34]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 22:52:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-10-17 23:16:48]

Patchset #6 (id:220001) has been deleted

[Sam McNally, 2016-10-17 23:17:00]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 23:17:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-10-17 23:20:01]

Patchset #6 (id:240001) has been deleted

[Sam McNally, 2016-10-17 23:20:12]

Patchset #5 (id:200001) has been deleted

[Sam McNally, 2016-10-17 23:20:20]

Patchset #4 (id:180001) has been deleted

[Sam McNally, 2016-10-17 23:23:02]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 23:23:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-10-17 23:24:36]

sammc@chromium.org changed reviewers:
+ piman@chromium.org, raymes@chromium.org

[Sam McNally, 2016-10-17 23:24:37]

+raymes for //content/renderer/pepper and //components/nacl/renderer

+piman for content/ppapi_plugin/ppapi_thread.cc

[raymes, 2016-10-17 23:28:53]

lgtm

https://codereview.chromium.org/2302053004/diff/260001/components/nacl/render...
File components/nacl/renderer/ppb_nacl_private_impl.cc (right):

https://codereview.chromium.org/2302053004/diff/260001/components/nacl/render...
components/nacl/renderer/ppb_nacl_private_impl.cc:136:
instance_info->channel_handle.mojo_handle.Close();
Should we DCHECK that it's a mojo_handle?

[commit-bot: I haz the power, 2016-10-18 00:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 00:41:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sam McNally, 2016-10-18 02:02:24]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 02:02:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-10-18 02:05:27]

Patchset #5 (id:280001) has been deleted

[Sam McNally, 2016-10-18 02:05:59]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 02:06:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-10-18 02:52:36]

LGTM. To clarify, mojo works in NaCl, yes?

Does that mean we can eventually remove the nacl message scanner code, if we
pass native handles with mojo?

[commit-bot: I haz the power, 2016-10-18 03:11:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 03:11:18]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-10-18 05:03:51]

On 2016/10/18 02:52:36, piman wrote:
> LGTM. To clarify, mojo works in NaCl, yes?
> 
> Does that mean we can eventually remove the nacl message scanner code, if we
> pass native handles with mojo?

Sadly no, mojo doesn't work inside the NaCl sandbox. I had a look at extending
mojo into the sandbox, but it wouldn't remove the need for the nacl message
scanner. Passing native handles into the sandbox requires wrapping and that
wrapping varies depending on the type of handle (socket, file or shared memory).

https://codereview.chromium.org/2302053004/diff/260001/components/nacl/render...
File components/nacl/renderer/ppb_nacl_private_impl.cc (right):

https://codereview.chromium.org/2302053004/diff/260001/components/nacl/render...
components/nacl/renderer/ppb_nacl_private_impl.cc:136:
instance_info->channel_handle.mojo_handle.Close();
On 2016/10/17 23:28:53, raymes wrote:
> Should we DCHECK that it's a mojo_handle?

Done.

[Sam McNally, 2016-10-18 05:54:38]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-10-18 05:54:38]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2302053004/#ps300001
(title: " ")

[commit-bot: I haz the power, 2016-10-18 05:54:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 06:01:12]

Description was changed from

==========
Use ChannelMojo for plugin-renderer channels.

patch from issue 2168523002 at patchset 20001
(http://crrev.com/2168523002#ps20001)

BUG=604282
COLLABORATOR=amistry@chromium.org
==========

to

==========
Use ChannelMojo for plugin-renderer channels.

patch from issue 2168523002 at patchset 20001
(http://crrev.com/2168523002#ps20001)

BUG=604282
COLLABORATOR=amistry@chromium.org
==========

[commit-bot: I haz the power, 2016-10-18 06:01:14]

Committed patchset #5 (id:300001)

[commit-bot: I haz the power, 2016-10-18 06:03:28]

Description was changed from

==========
Use ChannelMojo for plugin-renderer channels.

patch from issue 2168523002 at patchset 20001
(http://crrev.com/2168523002#ps20001)

BUG=604282
COLLABORATOR=amistry@chromium.org
==========

to

==========
Use ChannelMojo for plugin-renderer channels.

patch from issue 2168523002 at patchset 20001
(http://crrev.com/2168523002#ps20001)

BUG=604282
COLLABORATOR=amistry@chromium.org

Committed: https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1
Cr-Commit-Position: refs/heads/master@{#425900}
==========

[commit-bot: I haz the power, 2016-10-18 06:03:30]

Patchset 5 (id:??) landed as
https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1
Cr-Commit-Position: refs/heads/master@{#425900}