Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: master/skia_master_scripts/factory.py

Issue 23020034: Don't build debugger on 32-bit Linux (Closed) Base URL: http://skia.googlecode.com/svn/buildbot/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/tests/factory_configuration/expected/Build-Ubuntu12-GCC-x86-Debug » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 """Utility class to build the Skia master BuildFactory's. 6 """Utility class to build the Skia master BuildFactory's.
7 7
8 Based on gclient_factory.py and adds Skia-specific steps.""" 8 Based on gclient_factory.py and adds Skia-specific steps."""
9 9
10 10
(...skipping 671 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 self._build_targets = ['most'] 682 self._build_targets = ['most']
683 self.CommonSteps(clobber) 683 self.CommonSteps(clobber)
684 self.NonPerfSteps() 684 self.NonPerfSteps()
685 self.PerfSteps() 685 self.PerfSteps()
686 elif role == builder_name_schema.BUILDER_ROLE_BUILD: 686 elif role == builder_name_schema.BUILDER_ROLE_BUILD:
687 # Compile-only builder. 687 # Compile-only builder.
688 self.UpdateSteps() 688 self.UpdateSteps()
689 if not self._build_targets: 689 if not self._build_targets:
690 self._build_targets = ['skia_lib', 'tests', 'gm', 'tools', 'bench'] 690 self._build_targets = ['skia_lib', 'tests', 'gm', 'tools', 'bench']
691 if (('Win7' in self._builder_name and 'x86_64' in self._builder_name) or 691 if (('Win7' in self._builder_name and 'x86_64' in self._builder_name) or
692 ('Ubuntu' in self._builder_name and 'x86-' in self._builder_name) or
692 'Mac10.6' in self._builder_name): 693 'Mac10.6' in self._builder_name):
693 # Don't compile the debugger in 64-bit Win7 or Mac 10.6. 694 # Don't compile the debugger in 64-bit Win7 or Mac 10.6.
rmistry 2013/08/26 13:23:15 Add Ubuntu 32 bit here. Also, maybe useful to expa
borenet 2013/08/26 13:28:32 Done.
694 self._build_targets.append('most') 695 self._build_targets.append('most')
695 else: 696 else:
696 self._build_targets.append('everything') 697 self._build_targets.append('everything')
697 self.Compile(clobber=clobber, 698 self.Compile(clobber=clobber,
698 retry_without_werr_on_failure=True) 699 retry_without_werr_on_failure=True)
699 else: 700 else:
700 if not self._build_targets: 701 if not self._build_targets:
701 self._build_targets = ['most'] 702 self._build_targets = ['most']
702 self.CommonSteps(clobber) 703 self.CommonSteps(clobber)
703 if role == builder_name_schema.BUILDER_ROLE_TEST: 704 if role == builder_name_schema.BUILDER_ROLE_TEST:
704 # Test-running builder. 705 # Test-running builder.
705 self.NonPerfSteps() 706 self.NonPerfSteps()
706 if self._configuration == CONFIG_DEBUG: 707 if self._configuration == CONFIG_DEBUG:
707 # Debug-mode testers run all steps, but release-mode testers don't. 708 # Debug-mode testers run all steps, but release-mode testers don't.
708 self.PerfSteps() 709 self.PerfSteps()
709 elif role == builder_name_schema.BUILDER_ROLE_PERF: 710 elif role == builder_name_schema.BUILDER_ROLE_PERF:
710 # Perf-only builder. 711 # Perf-only builder.
711 if not self._perf_output_basedir: 712 if not self._perf_output_basedir:
712 raise ValueError( 713 raise ValueError(
713 'BuildPerfOnly requires perf_output_basedir to be defined.') 714 'BuildPerfOnly requires perf_output_basedir to be defined.')
714 if self._configuration != CONFIG_RELEASE: 715 if self._configuration != CONFIG_RELEASE:
715 raise ValueError('BuildPerfOnly should run in %s configuration.' % 716 raise ValueError('BuildPerfOnly should run in %s configuration.' %
716 CONFIG_RELEASE) 717 CONFIG_RELEASE)
717 self.PerfSteps() 718 self.PerfSteps()
718 self.Validate() 719 self.Validate()
719 return self 720 return self
OLDNEW
« no previous file with comments | « no previous file | tools/tests/factory_configuration/expected/Build-Ubuntu12-GCC-x86-Debug » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698