Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2302003003: [linter] Issue 295. Skip comment tokens with GitHub code blocks (in ```). (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +15 lines, -2 lines 2 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 3 months ago (2016-09-01 20:55:57 UTC) #1
pquitslund
LGTM!
4 years, 3 months ago (2016-09-01 21:05:56 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2302003003/diff/1/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/2302003003/diff/1/pkg/analyzer/lib/src/generated/parser.dart#newcode5187 pkg/analyzer/lib/src/generated/parser.dart:5187: if (comment.indexOf('```') != -1) { Do we care ...
4 years, 3 months ago (2016-09-01 21:06:58 UTC) #3
scheglov
https://codereview.chromium.org/2302003003/diff/1/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/2302003003/diff/1/pkg/analyzer/lib/src/generated/parser.dart#newcode5187 pkg/analyzer/lib/src/generated/parser.dart:5187: if (comment.indexOf('```') != -1) { On 2016/09/01 21:06:58, Brian ...
4 years, 3 months ago (2016-09-01 21:14:22 UTC) #4
scheglov
4 years, 3 months ago (2016-09-01 21:22:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
75d1ff092e24c1fc25824b415d637b856ce4a666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698