Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/mirrors/mirrors.dart

Issue 23020025: Implement ParameterMirror.{isFinal,hasDefaultValue,defaultValue}. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/lib/mirrors_impl.dart ('K') | « runtime/vm/parser.cc ('k') | tests/lib/lib.status » ('j') | tests/lib/mirrors/parameter_dart_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/mirrors/mirrors.dart
diff --git a/sdk/lib/mirrors/mirrors.dart b/sdk/lib/mirrors/mirrors.dart
index c22d3c3164e8d1bf673cbfbec46c8386c4810492..e993bd1590a011d3ae9aa07549570247f31ae527 100644
--- a/sdk/lib/mirrors/mirrors.dart
+++ b/sdk/lib/mirrors/mirrors.dart
@@ -1107,8 +1107,7 @@ abstract class ParameterMirror implements VariableMirror {
/**
* A mirror on the default value for this parameter, if it exists.
rmacnak 2013/08/23 23:15:27 And do what if it doesn't?
Michael Lippautz (Google) 2013/08/24 00:17:21 Done.
*/
- // TODO(ahe): This should return an InstanceMirror.
- String get defaultValue;
+ InstanceMirror get defaultValue;
}
/**
« runtime/lib/mirrors_impl.dart ('K') | « runtime/vm/parser.cc ('k') | tests/lib/lib.status » ('j') | tests/lib/mirrors/parameter_dart_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698