Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 23020018: MIPS: Remove wrong restriction in GenerateDeoptJumpTable. (Closed)

Created:
7 years, 4 months ago by palfia
Modified:
7 years, 4 months ago
Reviewers:
kisg, Paul Lind, kilvadyb, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Remove wrong restriction in GenerateDeoptJumpTable. * This Abort condition does not apply to MIPS, since the assembler can also emit long Branches automatically, when it is needed. TEST=mjsunit/math-floor-of-div,benchmarks/octane/gbemu,benchmarks/octane/mandreel BUG= Committed: https://code.google.com/p/v8/source/detail?r=16223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
7 years, 4 months ago (2013-08-17 01:36:44 UTC) #1
Paul Lind
LGTM, thanks for the fix.
7 years, 4 months ago (2013-08-19 04:56:59 UTC) #2
palfia
7 years, 4 months ago (2013-08-19 16:03:19 UTC) #3
Message was sent while issue was closed.
Committed manually as r16223.

Powered by Google App Engine
This is Rietveld 408576698