In chrome://crashes, re-read the crash list on page reload

chrome/browser/ui/webui/crashes_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/crashes_ui.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 71 matching lines @@
 
  private:
   // Asynchronously fetches the list of crashes. Called from JS.
   void HandleRequestCrashes(const ListValue* args);
 
   // Sends the recent crashes list JS.
   void UpdateUI();
 
   scoped_refptr<CrashUploadList> upload_list_;
   bool list_available_;
-  bool js_request_pending_;
+  bool first_load_;
 
   DISALLOW_COPY_AND_ASSIGN(CrashesDOMHandler);
 };
 
 CrashesDOMHandler::CrashesDOMHandler()
-    : list_available_(false), js_request_pending_(false) {
+    : list_available_(false), first_load_(true) {
   upload_list_ = CrashUploadList::Create(this);
 }
 
 CrashesDOMHandler::~CrashesDOMHandler() {
   upload_list_->ClearDelegate();
 }
 
 void CrashesDOMHandler::RegisterMessages() {
   upload_list_->LoadUploadListAsynchronously();
-
   web_ui()->RegisterMessageCallback("requestCrashList",
       base::Bind(&CrashesDOMHandler::HandleRequestCrashes,
                  base::Unretained(this)));
 }
 
 void CrashesDOMHandler::HandleRequestCrashes(const ListValue* args) {

[Lei Zhang, 2013/09/17 20:33:15]

I think this should be:

  if (first_load_) {
    first_load_ = false;
    if (list_available_) {
      UpdateUI();
    }
  } else {
    list_available_ = false;
    upload_list_->LoadUploadListAsynchronously();
  }

As is, if the load from RegisterMessages() happens too slowly, the else case
below will be triggered and another load request will be sent.

[achaulk1, 2013/09/17 21:21:51]

Ah, you're right it would do that.

-  if (!CrashesUI::CrashReportingUIEnabled() || list_available_)
+  if (first_load_ && list_available_) {
     UpdateUI();
-  else
-    js_request_pending_ = true;
+  } else {
+    list_available_ = false;
+    upload_list_->LoadUploadListAsynchronously();
+  }
+  first_load_ = false;
 }
 
 void CrashesDOMHandler::OnUploadListAvailable() {
   list_available_ = true;
-  if (js_request_pending_)
+  if (!first_load_)
     UpdateUI();
 }
 
 void CrashesDOMHandler::UpdateUI() {
   bool crash_reporting_enabled = CrashesUI::CrashReportingUIEnabled();
   ListValue crash_list;
 
   if (crash_reporting_enabled) {
     std::vector<CrashUploadList::UploadInfo> crashes;
     upload_list_->GetUploads(50, &crashes);
@@ skipping 52 matching lines @@
   PrefService* prefs = g_browser_process->local_state();
   return prefs->GetBoolean(prefs::kCrashReportingEnabled);
 #else
   PrefService* prefs = g_browser_process->local_state();
   return prefs->GetBoolean(prefs::kMetricsReportingEnabled);
 #endif
 #else
   return false;
 #endif
 }