In chrome://crashes, re-read the crash list on page reload

chrome/browser/upload_list.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/upload_list.h"
 
 #include <algorithm>
 #include <iterator>
 
 #include "base/bind.h"
@@ skipping 36 matching lines @@
       FROM_HERE,
       base::Bind(&UploadList::InformDelegateOfCompletion, this));
 }
 
 void UploadList::LoadUploadList() {
   if (base::PathExists(upload_log_path_)) {
     std::string contents;
     file_util::ReadFileToString(upload_log_path_, &contents);
     std::vector<std::string> log_entries;
     base::SplitStringAlongWhitespace(contents, &log_entries);
+    uploads_.clear();

[vapier, 2013/09/14 04:43:39]

i'm not sure this is correct.  the upload list class is used in places other
than just the crash reporter list.

[achaulk1, 2013/09/16 18:06:21]

It is, but they use the list in the same way that crash reporting did - load
once

[vapier, 2013/09/16 21:02:40]

if people are happy with changing the upload list for everyone, then that works
for me too.  i guess the existing code doesn't make much sense unless the source
list itself is fully cleared and only new entries get added.

it would make the calling code simpler imo ... otherwise you have to delete &
create a new object every time, or add a new func to the upload_list class that
lets you clear existing entries.

     ParseLogEntries(log_entries);
   }
 }
 
 void UploadList::AppendUploadInfo(const UploadInfo& info) {
   uploads_.push_back(info);
 }
 
 void UploadList::ParseLogEntries(
     const std::vector<std::string>& log_entries) {
@@ skipping 19 matching lines @@
     delegate_->OnUploadListAvailable();
 }
 
 void UploadList::GetUploads(unsigned int max_count,
                             std::vector<UploadInfo>* uploads) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   std::copy(uploads_.begin(),
             uploads_.begin() + std::min<size_t>(uploads_.size(), max_count),
             std::back_inserter(*uploads));
 }