In chrome://crashes, re-read the crash list on page reload

chrome/browser/ui/webui/crashes_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/crashes_ui.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 70 matching lines @@
   virtual void OnUploadListAvailable() OVERRIDE;
 
  private:
   // Asynchronously fetches the list of crashes. Called from JS.
   void HandleRequestCrashes(const ListValue* args);
 
   // Sends the recent crashes list JS.
   void UpdateUI();
 
   scoped_refptr<CrashUploadList> upload_list_;
   bool list_available_;

[vapier, 2013/09/14 04:43:39]

pretty sure this is now unused

[achaulk1, 2013/09/16 18:06:21]

Ah, yes it is

-  bool js_request_pending_;
 
   DISALLOW_COPY_AND_ASSIGN(CrashesDOMHandler);
 };
 
 CrashesDOMHandler::CrashesDOMHandler()
-    : list_available_(false), js_request_pending_(false) {
+    : list_available_(false) {
   upload_list_ = CrashUploadList::Create(this);
 }
 
 CrashesDOMHandler::~CrashesDOMHandler() {
   upload_list_->ClearDelegate();
 }
 
 void CrashesDOMHandler::RegisterMessages() {
-  upload_list_->LoadUploadListAsynchronously();
-
   web_ui()->RegisterMessageCallback("requestCrashList",
       base::Bind(&CrashesDOMHandler::HandleRequestCrashes,
                  base::Unretained(this)));
 }
 
 void CrashesDOMHandler::HandleRequestCrashes(const ListValue* args) {
-  if (!CrashesUI::CrashReportingUIEnabled() || list_available_)
-    UpdateUI();
-  else
-    js_request_pending_ = true;
+  upload_list_->LoadUploadListAsynchronously();
 }
 
 void CrashesDOMHandler::OnUploadListAvailable() {
   list_available_ = true;
-  if (js_request_pending_)
-    UpdateUI();
+  UpdateUI();
 }
 
 void CrashesDOMHandler::UpdateUI() {
   bool crash_reporting_enabled = CrashesUI::CrashReportingUIEnabled();
   ListValue crash_list;
 
   if (crash_reporting_enabled) {
     std::vector<CrashUploadList::UploadInfo> crashes;
     upload_list_->GetUploads(50, &crashes);
 
@@ skipping 51 matching lines @@
   PrefService* prefs = g_browser_process->local_state();
   return prefs->GetBoolean(prefs::kCrashReportingEnabled);
 #else
   PrefService* prefs = g_browser_process->local_state();
   return prefs->GetBoolean(prefs::kMetricsReportingEnabled);
 #endif
 #else
   return false;
 #endif
 }