Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/TabShellTabUtils.java

Issue 23020009: TabBase: Add ContentView/NativePage ownership (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase! Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/TabShellTabUtils.java
diff --git a/chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/TabShellTabUtils.java b/chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/TabShellTabUtils.java
index c9bc381c84edd697de5a93d989ee24726132e061..26d2fe36fe40efcc75fe774ea4b3292e48e15423 100644
--- a/chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/TabShellTabUtils.java
+++ b/chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/TabShellTabUtils.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.testshell;
+import org.chromium.chrome.browser.TabBase;
+import org.chromium.chrome.browser.TabObserver;
import org.chromium.content.browser.ContentViewClient;
import org.chromium.content.browser.test.util.CallbackHelper;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
@@ -25,7 +27,7 @@ public class TabShellTabUtils {
}
public static class TestCallbackHelperContainerForTab
- extends TestCallbackHelperContainer implements TestShellTabObserver {
+ extends TestCallbackHelperContainer implements TabObserver {
private final OnCloseTabHelper mOnCloseTabHelper;
public TestCallbackHelperContainerForTab(TestShellTab tab) {
super(createTestContentViewClientForTab(tab),
@@ -42,17 +44,21 @@ public class TabShellTabUtils {
}
@Override
- public void onLoadProgressChanged(TestShellTab tab, int progress) {
+ public void onLoadProgressChanged(TabBase tab, int progress) {
}
@Override
- public void onUpdateUrl(TestShellTab tab, String url) {
+ public void onUpdateUrl(TabBase tab, String url) {
}
@Override
- public void onCloseTab(TestShellTab tab) {
+ public void onDestroyed(TabBase tab) {
mOnCloseTabHelper.notifyCalled();
}
+
+ @Override
+ public void onContentChanged(TabBase tab) {
+ }
}
/**

Powered by Google App Engine
This is Rietveld 408576698