Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23020003: pdfviewer: debug code for drawText (show magenta background for text, to show text even when we fai… (Closed)

Created:
7 years, 4 months ago by edisonn
Modified:
7 years, 4 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

pdfviewer: 1) debug code for drawText (show magenta background for text, to show text even when we fail to load/show it), 2) some cleanup: refactor and rename classes and files Committed: https://code.google.com/p/skia/source/detail?r=10716

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+681 lines, -2889 lines) Patch
D experimental/PdfViewer/SkPdfBasics.h View 1 2 1 chunk +0 lines, -400 lines 0 comments Download
D experimental/PdfViewer/SkPdfBasics.cpp View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
M experimental/PdfViewer/SkPdfConfig.h View 1 2 1 chunk +1 line, -29 lines 0 comments Download
M experimental/PdfViewer/SkPdfFont.h View 1 2 13 chunks +41 lines, -24 lines 0 comments Download
M experimental/PdfViewer/SkPdfFont.cpp View 1 2 12 chunks +22 lines, -22 lines 0 comments Download
A + experimental/PdfViewer/SkPdfGraphicsState.h View 1 2 4 chunks +10 lines, -35 lines 0 comments Download
A + experimental/PdfViewer/SkPdfGraphicsState.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M experimental/PdfViewer/SkPdfRenderer.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M experimental/PdfViewer/SkPdfRenderer.cpp View 1 2 80 chunks +281 lines, -282 lines 0 comments Download
M experimental/PdfViewer/SkPdfUtils.h View 1 2 1 chunk +50 lines, -2 lines 0 comments Download
M experimental/PdfViewer/generate_code.py View 1 2 10 chunks +40 lines, -40 lines 0 comments Download
D experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.h View 1 2 1 chunk +0 lines, -105 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp View 1 2 1 chunk +0 lines, -579 lines 0 comments Download
A + experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.h View 1 2 6 chunks +12 lines, -12 lines 0 comments Download
A + experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.cpp View 1 2 24 chunks +51 lines, -54 lines 0 comments Download
A + experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.h View 1 2 27 chunks +102 lines, -76 lines 0 comments Download
A + experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.h View 1 2 6 chunks +11 lines, -11 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp View 1 2 24 chunks +44 lines, -44 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfObject.h View 1 2 1 chunk +0 lines, -1006 lines 0 comments Download
D experimental/PdfViewer/pdfparser/native/SkPdfObject.cpp View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
M gyp/pdfviewer.gyp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
edisonn
7 years, 4 months ago (2013-08-14 18:26:35 UTC) #1
Message was sent while issue was closed. 
Committed patchset #4 manually as r10716 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698