Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

Issue 2301993002: binding: Introduces ExceptionToPromiseScope. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
index ef1c905755ecb922bb978658e43166c1c0612e5b..60f29c689e22ac62c1d7cee939960e9a49b9d860 100644
--- a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
@@ -87,6 +87,7 @@ static void partial4StaticLongAttributeAttributeSetterCallback(const v8::Functio
static void voidMethodPartialOverload3Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
+
V8StringResource<> value;
{
value = info[0];
@@ -112,7 +113,6 @@ static void voidMethodPartialOverloadMethod(const v8::FunctionCallbackInfo<v8::V
break;
}
exceptionState.throwTypeError("No function was found that matched the signature provided.");
- return;
}
static void staticVoidMethodPartialOverload2Method(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -142,17 +142,17 @@ static void staticVoidMethodPartialOverloadMethod(const v8::FunctionCallbackInfo
break;
}
exceptionState.throwTypeError("No function was found that matched the signature provided.");
- return;
}
static void promiseMethodPartialOverload3Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
+
Document* document;
{
document = V8Document::toImplWithTypeCheck(info.GetIsolate(), info[0]);
if (!document) {
- v8SetReturnValue(info, ScriptPromise::rejectRaw(ScriptState::current(info.GetIsolate()), V8ThrowException::createTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("promiseMethodPartialOverload", "TestInterface", "parameter 1 is not of type 'Document'."))));
+ V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("promiseMethodPartialOverload", "TestInterface", "parameter 1 is not of type 'Document'."));
return;
}
}
@@ -175,12 +175,14 @@ static void promiseMethodPartialOverloadMethod(const v8::FunctionCallbackInfo<v8
break;
}
exceptionState.throwTypeError("No function was found that matched the signature provided.");
- v8SetReturnValue(info, exceptionState.reject(ScriptState::current(info.GetIsolate())).v8Value());
- return;
}
-static void staticPromiseMethodPartialOverload2MethodPromise(const v8::FunctionCallbackInfo<v8::Value>& info, ExceptionState& exceptionState)
+static void staticPromiseMethodPartialOverload2Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
+ ExceptionState exceptionState(info.GetIsolate(), ExceptionState::ExecutionContext, "TestInterface", "staticPromiseMethodPartialOverload");
+ ScriptState* scriptState = ScriptState::forFunctionObject(info);
+ ExceptionToPromiseScope exceptionToPromiseScope(info, scriptState, exceptionState);
+
V8StringResource<> value;
{
value = info[0];
@@ -190,14 +192,6 @@ static void staticPromiseMethodPartialOverload2MethodPromise(const v8::FunctionC
v8SetReturnValue(info, TestInterfacePartial3Implementation::staticPromiseMethodPartialOverload(value).v8Value());
}
-static void staticPromiseMethodPartialOverload2Method(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- ExceptionState exceptionState(ExceptionState::ExecutionContext, "staticPromiseMethodPartialOverload", "TestInterface", info.Holder(), info.GetIsolate());
- staticPromiseMethodPartialOverload2MethodPromise(info, exceptionState);
- if (exceptionState.hadException())
- v8SetReturnValue(info, exceptionState.reject(ScriptState::current(info.GetIsolate())).v8Value());
-}
-
static void staticPromiseMethodPartialOverloadMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
ExceptionState exceptionState(ExceptionState::ExecutionContext, "staticPromiseMethodPartialOverload", "TestInterface", info.Holder(), info.GetIsolate());
@@ -214,13 +208,12 @@ static void staticPromiseMethodPartialOverloadMethod(const v8::FunctionCallbackI
break;
}
exceptionState.throwTypeError("No function was found that matched the signature provided.");
- v8SetReturnValue(info, exceptionState.reject(ScriptState::current(info.GetIsolate())).v8Value());
- return;
}
static void partial2VoidMethod2Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
+
V8StringResource<> value;
{
value = info[0];
@@ -233,6 +226,7 @@ static void partial2VoidMethod2Method(const v8::FunctionCallbackInfo<v8::Value>&
static void partial2VoidMethod3Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
+
Node* node;
{
node = V8Node::toImplWithTypeCheck(info.GetIsolate(), info[0]);
@@ -264,17 +258,19 @@ static void partial2VoidMethodMethod(const v8::FunctionCallbackInfo<v8::Value>&
break;
}
exceptionState.throwTypeError("No function was found that matched the signature provided.");
- return;
}
static void partialVoidTestEnumModulesArgMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- ExceptionState exceptionState(ExceptionState::ExecutionContext, "partialVoidTestEnumModulesArgMethod", "TestInterface", info.Holder(), info.GetIsolate());
+ ExceptionState exceptionState(info.GetIsolate(), ExceptionState::ExecutionContext, "TestInterface", "partialVoidTestEnumModulesArgMethod");
+
if (UNLIKELY(info.Length() < 1)) {
- setMinimumArityTypeError(exceptionState, 1, info.Length());
+ throwMinimumArityError(exceptionState, 1, info.Length());
return;
}
+
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
+
V8StringResource<> arg;
{
arg = info[0];
@@ -323,12 +319,12 @@ static void partial2StaticVoidMethodMethod(const v8::FunctionCallbackInfo<v8::Va
break;
}
exceptionState.throwTypeError("No function was found that matched the signature provided.");
- return;
}
static void unscopeableVoidMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
+
TestInterfacePartial3Implementation::unscopeableVoidMethod(*impl);
}
@@ -340,6 +336,7 @@ static void unscopeableVoidMethodMethodCallback(const v8::FunctionCallbackInfo<v
static void partial4VoidMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());
+
TestInterfacePartial4::partial4VoidMethod(*impl);
}

Powered by Google App Engine
This is Rietveld 408576698