Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp

Issue 2301993002: binding: Introduces ExceptionToPromiseScope. (Closed)
Patch Set: Addressed review comments (rename, empty line). Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
index 4824e73e683d2f208579e8aac48bb0e695a97d93..0a979db995659ec69a8ca3c492722c4ebe4a5df0 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
@@ -56,17 +56,18 @@ namespace TestSpecialOperationsV8Internal {
static void namedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
+ TestSpecialOperations* impl = V8TestSpecialOperations::toImpl(info.Holder());
+
if (UNLIKELY(info.Length() < 1)) {
- V8ThrowException::throwException(info.GetIsolate(), V8ThrowException::createTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("namedItem", "TestSpecialOperations", ExceptionMessages::notEnoughArguments(1, info.Length()))));
+ V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("namedItem", "TestSpecialOperations", ExceptionMessages::notEnoughArguments(1, info.Length())));
return;
}
- TestSpecialOperations* impl = V8TestSpecialOperations::toImpl(info.Holder());
+
V8StringResource<> name;
- {
- name = info[0];
- if (!name.prepare())
- return;
- }
+ name = info[0];
+ if (!name.prepare())
+ return;
+
NodeOrNodeList result;
impl->getItem(name, result);
v8SetReturnValue(info, result);

Powered by Google App Engine
This is Rietveld 408576698