Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp

Issue 2301993002: binding: Introduces ExceptionToPromiseScope. (Closed)
Patch Set: Addressed review comments (rename, empty line). Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
index 00caa4b5f258bcc1cb55fb6ae73d5f1e7dc7612a..089ac2ba79fd7701b7a64c0c9efcc3ad4603ab08 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
@@ -75,25 +75,28 @@ void isTrustedAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>&
static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterfaceEventInitConstructor", info.Holder(), info.GetIsolate());
+ ExceptionState exceptionState(info.GetIsolate(), ExceptionState::ConstructionContext, "TestInterfaceEventInitConstructor");
+
if (UNLIKELY(info.Length() < 2)) {
exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(2, info.Length()));
return;
}
+
V8StringResource<> type;
TestInterfaceEventInit testInterfaceEventInit;
- {
- type = info[0];
- if (!type.prepare())
- return;
- if (!isUndefinedOrNull(info[1]) && !info[1]->IsObject()) {
- exceptionState.throwTypeError("parameter 2 ('testInterfaceEventInit') is not an object.");
- return;
- }
- V8TestInterfaceEventInit::toImpl(info.GetIsolate(), info[1], testInterfaceEventInit, exceptionState);
- if (exceptionState.hadException())
- return;
+ type = info[0];
+ if (!type.prepare())
+ return;
+
+ if (!isUndefinedOrNull(info[1]) && !info[1]->IsObject()) {
+ exceptionState.throwTypeError("parameter 2 ('testInterfaceEventInit') is not an object.");
+
+ return;
}
+ V8TestInterfaceEventInit::toImpl(info.GetIsolate(), info[1], testInterfaceEventInit, exceptionState);
+ if (exceptionState.hadException())
+ return;
+
TestInterfaceEventInitConstructor* impl = TestInterfaceEventInitConstructor::create(type, testInterfaceEventInit);
v8::Local<v8::Object> wrapper = info.Holder();
wrapper = impl->associateWithWrapper(info.GetIsolate(), &V8TestInterfaceEventInitConstructor::wrapperTypeInfo, wrapper);

Powered by Google App Engine
This is Rietveld 408576698