third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 2301993002: binding: Introduces ExceptionToPromiseScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2301993002: binding: Introduces ExceptionToPromiseScope. (Closed)

Patch Set: Removed throwMinimumArityError family. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/GeneratedCodeHelper.h ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp ('k') | third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h » ('j') | third_party/WebKit/Source/bindings/scripts/utilities.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index 2689e4738e6bf5d8698aeee1bd91ebb95689a6ff..4de6cb0b5d4e3fc2e418dd460154a7b2b89ea8ce 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -154,7 +154,7 @@ void V8Window::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::Value>

{

ExceptionState exceptionState(ExceptionState::ExecutionContext, "postMessage", "Window", info.Holder(), info.GetIsolate());

if (UNLIKELY(info.Length() < 2)) {

- setMinimumArityTypeError(exceptionState, 2, info.Length());

+ exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(2, info.Length()));

return;

}