Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2301973002: More DDC mirrors support (Closed)

Created:
4 years, 3 months ago by vsm
Modified:
4 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More DDC mirrors support (Note, this is a straight migration of the old DDC repo CL. :-)) R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/9af2fb0115818bfd178ef42f3b2371ed4411bed8

Patch Set 1 #

Total comments: 1

Patch Set 2 : Format fixes per comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+574 lines, -273 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 7 chunks +126 lines, -37 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 3 chunks +1 line, -5 lines 0 comments Download
M pkg/dev_compiler/test/browser/runtime_tests.js View 1 7 chunks +11 lines, -11 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/mirrors/metadata_constructed_constant_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/mirrors/metadata_constructor_arguments_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/mirrors/metadata_nested_constructor_call_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/closure.js View 1 2 chunks +23 lines, -2 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/expect.js View 1 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js View 1 2 chunks +7 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js.map View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/global_compile.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 6 chunks +58 lines, -6 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 6 chunks +333 lines, -206 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 3 months ago (2016-09-01 13:07:48 UTC) #3
Jennifer Messerly
lgtm! https://codereview.chromium.org/2301973002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2301973002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart#newcode1754 pkg/dev_compiler/lib/src/compiler/code_generator.dart:1754: if (!tInstanceFields.isEmpty) style nit: add curly braces since ...
4 years, 3 months ago (2016-09-01 16:42:43 UTC) #4
vsm
4 years, 3 months ago (2016-09-01 17:13:38 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:10001) manually as
9af2fb0115818bfd178ef42f3b2371ed4411bed8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698