Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2301963002: Revert of [regexp] Port RegExp getters and setters (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Port RegExp getters and setters (patchset #4 id:60001 of https://codereview.chromium.org/2305573002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/9437 Original issue's description: > [regexp] Port RegExp getters and setters > > BUG=v8:5339 > > Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9 > Cr-Commit-Position: refs/heads/master@{#39076} TBR=bmeurer@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5339 Committed: https://crrev.com/6c25d789ba250c7ce1472cc5834a21650ef36ee6 Cr-Commit-Position: refs/heads/master@{#39085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -426 lines) Patch
M src/bootstrapper.cc View 3 chunks +24 lines, -146 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -23 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 chunk +0 lines, -244 lines 0 comments Download
M src/heap-symbols.h View 5 chunks +0 lines, -5 lines 0 comments Download
M src/js/regexp.js View 3 chunks +224 lines, -3 lines 0 comments Download
M src/messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/messages.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [regexp] Port RegExp getters and setters
4 years, 3 months ago (2016-09-01 12:50:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301963002/1
4 years, 3 months ago (2016-09-01 12:50:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 12:50:31 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 12:50:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c25d789ba250c7ce1472cc5834a21650ef36ee6
Cr-Commit-Position: refs/heads/master@{#39085}

Powered by Google App Engine
This is Rietveld 408576698