Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/crash_upload_list/crash_upload_list_android.cc

Issue 2301943003: Show not uploaded crashes for Android. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/crash_upload_list/crash_upload_list_android.h"
6
7 #include "base/files/file.h"
8 #include "base/files/file_enumerator.h"
9 #include "base/files/file_util.h"
10 #include "base/threading/sequenced_worker_pool.h"
11
12 CrashUploadListAndroid::CrashUploadListAndroid(
13 Delegate* delegate,
14 const base::FilePath& upload_log_path,
15 const scoped_refptr<base::SequencedWorkerPool>& worker_pool)
16 : CrashUploadList(delegate, upload_log_path, worker_pool) {}
17
18 CrashUploadListAndroid::~CrashUploadListAndroid() {}
19
20 void CrashUploadListAndroid::LoadUploadList(
21 std::vector<UploadList::UploadInfo>* uploads) {
22 // This will load the list of successfully uploaded logs.
23 CrashUploadList::LoadUploadList(uploads);
24
25 LoadUnsuccessfulUploadList(uploads);
26 }
27
28 void CrashUploadListAndroid::LoadUnsuccessfulUploadList(
29 std::vector<UploadInfo>* uploads) {
30 const char* unsuccessful_uploads = ".dmp";
31 const char* skipped_uploads = ".skipped";
32
33 base::FileEnumerator files(upload_log_path().DirName(), false,
34 base::FileEnumerator::FILES);
35 for (base::FilePath file = files.Next(); !file.empty(); file = files.Next()) {
36 if (file.value().find(unsuccessful_uploads) == std::string::npos &&
37 file.value().find(skipped_uploads) == std::string::npos)
38 continue;
39
40 base::File::Info info;
41 base::Time creation_time;
42 if (base::GetFileInfo(file, &info))
43 creation_time = info.creation_time;
Lei Zhang 2016/09/07 19:31:50 But if GetFileInfo() fails, that likely means some
gayane -on leave until 09-2017 2016/09/07 20:20:32 Done.
44
45 // Crash reports can have multiple extensions.
46 file = file.BaseName();
47 while (file != file.RemoveExtension())
48 file = file.RemoveExtension();
49
50 // ID is the last part of the file name. e.g.
51 // chromium-renderer-minidump-f297dbcba7a2d0bb.
52 std::string id = file.value();
53 std::size_t pos = id.find_last_of("-");
54 if (pos == std::string::npos)
55 continue;
56
57 id = id.substr(pos + 1);
58 UploadList::UploadInfo upload(std::string(), base::Time(), id,
59 creation_time,
60 UploadList::UploadInfo::State::NotUploaded);
61 uploads->push_back(upload);
62 }
63 }
OLDNEW
« no previous file with comments | « chrome/browser/crash_upload_list/crash_upload_list_android.h ('k') | components/upload_list/upload_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698