|
Spin button in input[type=number] should not ignore paddings.
The old behavior was to emulate Windows spin button appearance. Now
we don't use Windows-native controls and don't need to emulate it.
Implementation:
This CL removes special layout code for spin buttons in RenderTextControlSingleLine,
and the spin button layout relies on CSS flexible box.
As for Mac, we can't stretch NSStepper to arbitrary sizes. We need to
apply align-item:center. Also, adjust control size threshold because
spin buttons need to fit into the font height.
Test:
* We need to do rebaseline for some layout tests.
* This CL removes fast/forms/number/number-large-padding.html,
which made sense for the special layout.
* Add font-size to number-spinbutton-in-multi-column.html
because OSX spin button height depends on font size, and we don't
stretch it.
BUG= 128957, 330117, 356939
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171315
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+111 lines, -160 lines) |
Patch |
 |
M |
LayoutTests/TestExpectations
|
View
|
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/forms/number/number-large-padding.html
|
View
|
|
1 chunk |
+0 lines, -29 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/forms/number/number-large-padding-expected.txt
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/forms/number/number-spinbutton-in-multi-column.html
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/number/number-appearance-datalist-expected.png
|
View
|
|
Binary file |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/number/number-appearance-datalist-expected.txt
|
View
|
|
2 chunks |
+6 lines, -8 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/number/number-appearance-rtl-expected.png
|
View
|
|
Binary file |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/number/number-appearance-rtl-expected.txt
|
View
|
|
2 chunks |
+15 lines, -16 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
|
View
|
|
Binary file |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt
|
View
|
|
2 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/platform/win/fast/speech/input-appearance-numberandspeech-expected.txt
|
View
|
|
1 chunk |
+64 lines, -64 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/html.css
|
View
|
|
2 chunks |
+4 lines, -9 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/themeMac.css
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/rendering/RenderTextControlSingleLine.cpp
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
Source/platform/mac/ThemeMac.mm
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|