Rename SloppyBlockWithEvalContextExtension to ContextExtension

Rename SloppyBlockWithEvalContextExtension to ContextExtension

The plan is to also use it for With and Catch scopes, so all kinds of
contexts have a pointer back to their ScopeInfo

R=neis@chromium.org,marja@chromium.org
BUG=v8:5215
Committed: https://crrev.com/50d54ee2e30ea7039b97a90832cc40afe337e264
Cr-Commit-Position: refs/heads/master@{#39092}

[jochen (gone - plz use gerrit), 2016-09-01 11:58:00]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 11:58:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-01 11:58:10]

Description was changed from

==========
Rename SloppyBlockWithEvalContextExtension to ContextExtension

The plan is to also use it for With and Catch scopes, so all kinds of
contexts have a pointer back to their ScopeInfo

R=neis@chromium.org,marja@chromium.org
BUG=
==========

to

==========
Rename SloppyBlockWithEvalContextExtension to ContextExtension

The plan is to also use it for With and Catch scopes, so all kinds of
contexts have a pointer back to their ScopeInfo

R=neis@chromium.org,marja@chromium.org
BUG=v8:5215
==========

[jochen (gone - plz use gerrit), 2016-09-01 11:58:16]

ptal

[commit-bot: I haz the power, 2016-09-01 12:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 12:19:54]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/13484)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[jochen (gone - plz use gerrit), 2016-09-01 12:22:22]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 12:22:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 12:46:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 12:46:31]

Dry run: This issue passed the CQ dry run.

[neis, 2016-09-01 12:57:08]

lgtm modulo comments comments.

https://codereview.chromium.org/2301913002/diff/20001/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/2301913002/diff/20001/src/contexts.h#newcode301
src/contexts.h:301: // [ extension ]  A pointer to an ContextExtension object,
or "the hole". Used
s/an/a/

Could you make the comment more accurate? The first sentence is still very
misleading.

Also, we should rename this slot from "extension" to "data" or "extra" or
something less confusing in the future.

https://codereview.chromium.org/2301913002/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2301913002/diff/20001/src/objects.h#newcode6656
src/objects.h:6656: // a sloppy direct eval, or for with and catch scopes. (In
no other case both
Please clarify this comment. The first sentence should mention with and catch
contexts, if I understand correctly.

[jochen (gone - plz use gerrit), 2016-09-01 14:34:57]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-09-01 14:34:58]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2301913002/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2016-09-01 14:35:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 15:03:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 15:04:11]

Description was changed from

==========
Rename SloppyBlockWithEvalContextExtension to ContextExtension

The plan is to also use it for With and Catch scopes, so all kinds of
contexts have a pointer back to their ScopeInfo

R=neis@chromium.org,marja@chromium.org
BUG=v8:5215
==========

to

==========
Rename SloppyBlockWithEvalContextExtension to ContextExtension

The plan is to also use it for With and Catch scopes, so all kinds of
contexts have a pointer back to their ScopeInfo

R=neis@chromium.org,marja@chromium.org
BUG=v8:5215

Committed: https://crrev.com/50d54ee2e30ea7039b97a90832cc40afe337e264
Cr-Commit-Position: refs/heads/master@{#39092}
==========

[commit-bot: I haz the power, 2016-09-01 15:04:12]

Patchset 3 (id:??) landed as
https://crrev.com/50d54ee2e30ea7039b97a90832cc40afe337e264
Cr-Commit-Position: refs/heads/master@{#39092}