Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2301903004: Skip accessibility focus on tab in favor of close button (Closed)

Created:
4 years, 3 months ago by kraush
Modified:
4 years, 3 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip accessibility focus on tab in favor of close button The tab will always be checked first in the accessibility order since its x coordinate is "left" of the close button. However, visually the x button should be considered to be in the foreground when using Explore by Touch. With this change, the tab will return false when being checked to be hit by explore by touch when we know the close button will also be hit. BUG=641141 Committed: https://crrev.com/24759a90d46ce86537be0b84241964f3ffaf6cc9 Cr-Commit-Position: refs/heads/master@{#416292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kraush
Hi Theresa
4 years, 3 months ago (2016-09-02 14:39:25 UTC) #2
kraush
Argh, hit the wrong button with my first message! Full message: Hi Theresa, Can you ...
4 years, 3 months ago (2016-09-02 14:40:08 UTC) #3
Theresa
LTGM - thank you!
4 years, 3 months ago (2016-09-02 16:43:32 UTC) #4
Theresa
*LGTM
4 years, 3 months ago (2016-09-02 16:43:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301903004/1
4 years, 3 months ago (2016-09-02 16:44:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 17:31:07 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 17:34:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24759a90d46ce86537be0b84241964f3ffaf6cc9
Cr-Commit-Position: refs/heads/master@{#416292}

Powered by Google App Engine
This is Rietveld 408576698