Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2301903002: [turbofan] Properly look through FinishRegion in alias analysis. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly look through FinishRegion in alias analysis. For two FinishRegion nodes, the alias analysis returned "may alias" even without properly looking through them. Drive-by-fix: Add meaningful output for --trace-turbo-load-elimination. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/9f37e303c3fab8146826a01ae442ef27c3cec4aa Cr-Commit-Position: refs/heads/master@{#39075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -19 lines) Patch
M src/compiler/load-elimination.h View 4 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/load-elimination.cc View 6 chunks +99 lines, -19 lines 0 comments Download
M test/unittests/compiler/load-elimination-unittest.cc View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-01 10:16:59 UTC) #1
Jarin
lgtm, thanks!
4 years, 3 months ago (2016-09-01 10:31:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301903002/1
4 years, 3 months ago (2016-09-01 10:32:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 10:50:12 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 10:50:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f37e303c3fab8146826a01ae442ef27c3cec4aa
Cr-Commit-Position: refs/heads/master@{#39075}

Powered by Google App Engine
This is Rietveld 408576698