Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2301873003: Refuse to show Alt+Tab UI concurrently with virtual keyboard. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Refuse to show Alt+Tab UI concurrently with virtual keyboard. Overview mode is probably more useful to people who are trying to use a touch screen. Simply no-op on Alt+Tab when the virtual keyboard's showing. BUG=638269 Review-Url: https://codereview.chromium.org/2256283003 Cr-Commit-Position: refs/heads/master@{#414731} (cherry picked from commit 252dbee7b15f43aa53242b68eb1bc41b272eaf26)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M ash/common/accelerators/accelerator_controller.cc View 5 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accelerators/accelerator.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Evan Stade
4 years, 3 months ago (2016-09-01 21:22:42 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
470cd904273b8fe89f8d73dfef72b9d72f9d01dd.

Powered by Google App Engine
This is Rietveld 408576698