Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2301873002: [wasm] Read global names only if their name length is valid. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Read global names only if their name length is valid. BUG=chromium:642987 R=titzer@chromium.org TEST=module-decoder-unittest.cc:GlobalWithInvalidNameLength Committed: https://crrev.com/5e7428b5b13ca50f77a027409eaf0b0d99dfaf72 Cr-Commit-Position: refs/heads/master@{#39071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/wasm/module-decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ahaas
4 years, 3 months ago (2016-09-01 09:12:32 UTC) #1
titzer
lgtm
4 years, 3 months ago (2016-09-01 09:22:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301873002/1
4 years, 3 months ago (2016-09-01 09:22:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 09:52:27 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 09:52:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e7428b5b13ca50f77a027409eaf0b0d99dfaf72
Cr-Commit-Position: refs/heads/master@{#39071}

Powered by Google App Engine
This is Rietveld 408576698