Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2301863002: [interpreter] Strengthen a DCHECK. (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
adamk, rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Strengthen a DCHECK. There are no CONST function declarations. Also make check independent of variable location. R=adamk@chromium.org, rmcilroy@chromium.org BUG= Committed: https://crrev.com/494e2493f2850d19d800d15890d26c077ed4ca3a Cr-Commit-Position: refs/heads/master@{#39182}

Patch Set 1 #

Patch Set 2 : Move out of switch, eliminate CONST case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
neis
4 years, 3 months ago (2016-09-01 08:19:16 UTC) #1
adamk
lgtm
4 years, 3 months ago (2016-09-01 17:12:23 UTC) #2
neis
As Adam pointed out in a different CL, we should never see a CONST variable ...
4 years, 3 months ago (2016-09-02 08:07:18 UTC) #4
adamk
still lgtm
4 years, 3 months ago (2016-09-02 17:09:32 UTC) #10
rmcilroy
LGTM thanks.
4 years, 3 months ago (2016-09-05 09:51:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301863002/20001
4 years, 3 months ago (2016-09-05 15:36:39 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-05 16:02:43 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 16:03:00 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/494e2493f2850d19d800d15890d26c077ed4ca3a
Cr-Commit-Position: refs/heads/master@{#39182}

Powered by Google App Engine
This is Rietveld 408576698