Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2301853002: [turbofan] Improve message for unexpected opcode in simplified lowering. (Closed)

Created:
4 years, 3 months ago by Jarin
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve message for unexpected opcode in simplified lowering. The main goal is to have the opcode number on the stack, so that we can extract it from minidumps. Committed: https://crrev.com/706cbe384017b1894ea6ee273c32cebd5c1d4329 Cr-Commit-Position: refs/heads/master@{#39066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Jarin
Could you take a look, please?
4 years, 3 months ago (2016-09-01 07:13:27 UTC) #4
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-01 07:17:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301853002/1
4 years, 3 months ago (2016-09-01 07:50:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 07:52:41 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 07:53:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/706cbe384017b1894ea6ee273c32cebd5c1d4329
Cr-Commit-Position: refs/heads/master@{#39066}

Powered by Google App Engine
This is Rietveld 408576698