content/browser/accessibility/browser_accessibility_win_unittest.cc - Issue 2301833005: Get rid of AX_LINE_BREAKS attribute to improve performance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win_unittest.cc

Issue 2301833005: Get rid of AX_LINE_BREAKS attribute to improve performance. (Closed)

Patch Set: Re-worded comment. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/renderer/accessibility/blink_ax_tree_source.cc » ('j') | ui/accessibility/ax_node.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win_unittest.cc

diff --git a/content/browser/accessibility/browser_accessibility_win_unittest.cc b/content/browser/accessibility/browser_accessibility_win_unittest.cc

index 8e0a59e5b2b7e4b4f65c7325d7b5d6d664e9f664..a37b7808d863cfa658696a8959435405e96e8d0b 100644

--- a/content/browser/accessibility/browser_accessibility_win_unittest.cc

+++ b/content/browser/accessibility/browser_accessibility_win_unittest.cc

@@ -344,8 +344,8 @@ TEST_F(BrowserAccessibilityTest, TestTextBoundaries) {

text_field.SetValue(text_value);

std::vector<int32_t> line_start_offsets;

line_start_offsets.push_back(15);

- text_field.AddIntListAttribute(

- ui::AX_ATTR_LINE_BREAKS, line_start_offsets);

+ text_field.AddIntListAttribute(ui::AX_ATTR_CACHED_LINE_STARTS,

+ line_start_offsets);

text_field.child_ids.push_back(3);

text_field.child_ids.push_back(5);

text_field.child_ids.push_back(6);