Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 2301833005: Get rid of AX_LINE_BREAKS attribute to improve performance. (Closed)
Patch Set: Re-worded comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_cocoa.mm
diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm
index a0a8338f3f294ec228f5613173c49785afc1e264..f0dc23827a78ca158623a549b9316d1bf17617dd 100644
--- a/content/browser/accessibility/browser_accessibility_cocoa.mm
+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
@@ -1013,8 +1013,8 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
if (selStart > selEnd)
std::swap(selStart, selEnd);
- const std::vector<int32_t>& line_breaks =
- browserAccessibility_->GetIntListAttribute(ui::AX_ATTR_LINE_BREAKS);
+ const std::vector<int> line_breaks =
+ browserAccessibility_->GetLineStartOffsets();
for (int i = 0; i < static_cast<int>(line_breaks.size()); ++i) {
if (line_breaks[i] > selStart)
return [NSNumber numberWithInt:i];
@@ -1992,8 +1992,8 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
if (![self instanceActive])
return nil;
- const std::vector<int32_t>& line_breaks =
- browserAccessibility_->GetIntListAttribute(ui::AX_ATTR_LINE_BREAKS);
+ const std::vector<int> line_breaks =
+ browserAccessibility_->GetLineStartOffsets();
base::string16 value = browserAccessibility_->GetValue();
int len = static_cast<int>(value.size());

Powered by Google App Engine
This is Rietveld 408576698