Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Side by Side Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 2301833004: [wasm] Trap handling: ProtectedLoad instruction (Closed)
Patch Set: Add VisitProtectedLoad stubs for other architectures Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/arm64/instruction-selector-arm64.cc ('k') | src/compiler/instruction-selector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 InstructionOperand outputs[1]; 243 InstructionOperand outputs[1];
244 outputs[0] = g.DefineAsRegister(node); 244 outputs[0] = g.DefineAsRegister(node);
245 InstructionOperand inputs[3]; 245 InstructionOperand inputs[3];
246 size_t input_count = 0; 246 size_t input_count = 0;
247 AddressingMode mode = 247 AddressingMode mode =
248 g.GetEffectiveAddressMemoryOperand(node, inputs, &input_count); 248 g.GetEffectiveAddressMemoryOperand(node, inputs, &input_count);
249 InstructionCode code = opcode | AddressingModeField::encode(mode); 249 InstructionCode code = opcode | AddressingModeField::encode(mode);
250 Emit(code, 1, outputs, input_count, inputs); 250 Emit(code, 1, outputs, input_count, inputs);
251 } 251 }
252 252
253 void InstructionSelector::VisitProtectedLoad(Node* node) {
254 // TODO(eholk)
255 UNIMPLEMENTED();
256 }
253 257
254 void InstructionSelector::VisitStore(Node* node) { 258 void InstructionSelector::VisitStore(Node* node) {
255 IA32OperandGenerator g(this); 259 IA32OperandGenerator g(this);
256 Node* base = node->InputAt(0); 260 Node* base = node->InputAt(0);
257 Node* index = node->InputAt(1); 261 Node* index = node->InputAt(1);
258 Node* value = node->InputAt(2); 262 Node* value = node->InputAt(2);
259 263
260 StoreRepresentation store_rep = StoreRepresentationOf(node->op()); 264 StoreRepresentation store_rep = StoreRepresentationOf(node->op());
261 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind(); 265 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind();
262 MachineRepresentation rep = store_rep.representation(); 266 MachineRepresentation rep = store_rep.representation();
(...skipping 1450 matching lines...) Expand 10 before | Expand all | Expand 10 after
1713 // static 1717 // static
1714 MachineOperatorBuilder::AlignmentRequirements 1718 MachineOperatorBuilder::AlignmentRequirements
1715 InstructionSelector::AlignmentRequirements() { 1719 InstructionSelector::AlignmentRequirements() {
1716 return MachineOperatorBuilder::AlignmentRequirements:: 1720 return MachineOperatorBuilder::AlignmentRequirements::
1717 FullUnalignedAccessSupport(); 1721 FullUnalignedAccessSupport();
1718 } 1722 }
1719 1723
1720 } // namespace compiler 1724 } // namespace compiler
1721 } // namespace internal 1725 } // namespace internal
1722 } // namespace v8 1726 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/arm64/instruction-selector-arm64.cc ('k') | src/compiler/instruction-selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698