Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: src/compiler/arm/instruction-selector-arm.cc

Issue 2301833004: [wasm] Trap handling: ProtectedLoad instruction (Closed)
Patch Set: Add VisitProtectedLoad stubs for other architectures Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/base/bits.h" 6 #include "src/base/bits.h"
7 #include "src/compiler/instruction-selector-impl.h" 7 #include "src/compiler/instruction-selector-impl.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 10
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
405 case MachineRepresentation::kSimd128: // Fall through. 405 case MachineRepresentation::kSimd128: // Fall through.
406 case MachineRepresentation::kNone: 406 case MachineRepresentation::kNone:
407 UNREACHABLE(); 407 UNREACHABLE();
408 return; 408 return;
409 } 409 }
410 410
411 InstructionOperand output = g.DefineAsRegister(node); 411 InstructionOperand output = g.DefineAsRegister(node);
412 EmitLoad(this, opcode, &output, base, index); 412 EmitLoad(this, opcode, &output, base, index);
413 } 413 }
414 414
415 void InstructionSelector::VisitProtectedLoad(Node* node) {
416 // TODO(eholk)
417 UNIMPLEMENTED();
418 }
415 419
416 void InstructionSelector::VisitStore(Node* node) { 420 void InstructionSelector::VisitStore(Node* node) {
417 ArmOperandGenerator g(this); 421 ArmOperandGenerator g(this);
418 Node* base = node->InputAt(0); 422 Node* base = node->InputAt(0);
419 Node* index = node->InputAt(1); 423 Node* index = node->InputAt(1);
420 Node* value = node->InputAt(2); 424 Node* value = node->InputAt(2);
421 425
422 StoreRepresentation store_rep = StoreRepresentationOf(node->op()); 426 StoreRepresentation store_rep = StoreRepresentationOf(node->op());
423 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind(); 427 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind();
424 MachineRepresentation rep = store_rep.representation(); 428 MachineRepresentation rep = store_rep.representation();
(...skipping 1838 matching lines...) Expand 10 before | Expand all | Expand 10 after
2263 Vector<MachineType> req_aligned = Vector<MachineType>::New(2); 2267 Vector<MachineType> req_aligned = Vector<MachineType>::New(2);
2264 req_aligned[0] = MachineType::Float32(); 2268 req_aligned[0] = MachineType::Float32();
2265 req_aligned[1] = MachineType::Float64(); 2269 req_aligned[1] = MachineType::Float64();
2266 return MachineOperatorBuilder::AlignmentRequirements:: 2270 return MachineOperatorBuilder::AlignmentRequirements::
2267 SomeUnalignedAccessUnsupported(req_aligned, req_aligned); 2271 SomeUnalignedAccessUnsupported(req_aligned, req_aligned);
2268 } 2272 }
2269 2273
2270 } // namespace compiler 2274 } // namespace compiler
2271 } // namespace internal 2275 } // namespace internal
2272 } // namespace v8 2276 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698