Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2301833002: Travis config (Closed)

Created:
4 years, 3 months ago by vsm
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix status #

Total comments: 1

Patch Set 3 : Point pubspec to analyzer in SDK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -6 lines) Patch
A .travis.yml View 1 1 chunk +68 lines, -0 lines 0 comments Download
M pkg/dev_compiler/pubspec.lock View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/dev_compiler/pubspec.yaml View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
vsm
4 years, 3 months ago (2016-09-01 02:42:09 UTC) #3
vsm
https://codereview.chromium.org/2301833002/diff/20001/pkg/dev_compiler/test/browser/language_tests.js File pkg/dev_compiler/test/browser/language_tests.js (right): https://codereview.chromium.org/2301833002/diff/20001/pkg/dev_compiler/test/browser/language_tests.js#newcode579 pkg/dev_compiler/test/browser/language_tests.js:579: 'point_test': ['unittest', 'skip', 'fail'], Reapplying fix from old repo: ...
4 years, 3 months ago (2016-09-01 03:05:50 UTC) #6
kevmoo
lgtm
4 years, 3 months ago (2016-09-01 15:29:33 UTC) #7
vsm
Committed patchset #3 (id:40001) manually as b220f639540a9d7366acab0f5777fdeab796e0f0 (presubmit successful).
4 years, 3 months ago (2016-09-01 15:33:59 UTC) #9
Bill Hesse
4 years, 3 months ago (2016-09-01 15:34:55 UTC) #10
Message was sent while issue was closed.
LGTM.  The pubspec.yaml dependency_overrides will cause a problem with the
pkgbuild/pkg/dev_compiler test, which tries to copy the package to a new
location and run pub get on it and pub build on it.  Just skip the test in
pkg/pkgbuild.status if it fails.  Actually, it is timing out now, so I would
want to skip it anyway.  Please add to this CL if you can.

Powered by Google App Engine
This is Rietveld 408576698