Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 230183002: Remove unnecessary Platform::createMessagePortChannel method (Closed)

Created:
6 years, 8 months ago by darin (slow to review)
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove unnecessary Platform::createMessagePortChannel method Introduce WebMessagePortChannelImpl::CreatePair to avoid duplicated code and to avoid using the WebMessagePortChannel::entangle method. BUG=361001 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -36 lines) Patch
M content/child/webmessageportchannel_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/webmessageportchannel_impl.cc View 3 chunks +21 lines, -6 lines 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
darin (slow to review)
6 years, 8 months ago (2014-04-09 04:58:52 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-09 06:38:23 UTC) #2
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 8 months ago (2014-04-09 06:40:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 06:46:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 06:53:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 07:00:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 07:06:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 07:13:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 07:20:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 07:26:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 07:32:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 07:41:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 07:48:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 07:54:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 08:02:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 08:09:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 08:16:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 09:09:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 09:17:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 09:24:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 09:32:25 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 09:44:40 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 09:53:43 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 11:14:03 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/230183002/1
6 years, 8 months ago (2014-04-09 11:25:03 UTC) #25
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 12:49:29 UTC) #26
Message was sent while issue was closed. 
Change committed as 262669

Powered by Google App Engine
This is Rietveld 408576698