third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html - Issue 2301823002: Reordering media controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html

Issue 2301823002: Reordering media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls

Patch Set: addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-multiple-tracks.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-track-selection-menu.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html

diff --git a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html

index 930ca1ea9835fcd27aae23de2d5433632d14ea79..8be5c15d75cfd10c46c03c1a031f257f505eda09 100644

--- a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html

+++ b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html

@@ -28,7 +28,7 @@ async_test(function(t) {

// Cast option in overflow should no longer be visible, but the other

// options should all be.

var buttonsWithoutCast = overflowButtonsCSS;

- buttonsWithoutCast[1] = undefined;

+ buttonsWithoutCast[OverflowMenuButtons.CAST] = undefined;

internals.mediaPlayerRemoteRouteAvailabilityChanged(video, false);

var children = overflowList.children;

@@ -42,12 +42,12 @@ async_test(function(t) {

}

internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);

- assert_not_equals(getComputedStyle(children[1]).display, "none");

+ assert_not_equals(getComputedStyle(children[OverflowMenuButtons.CAST]).display, "none");

// Removing closed captions hides button in overflow menu

- assert_not_equals(getComputedStyle(children[2]).display, "none");

+ assert_not_equals(getComputedStyle(children[OverflowMenuButtons.CLOSED_CAPTIONS]).display, "none");

video.removeChild(trackElement);

- assert_equals(getComputedStyle(children[2]).display, "none");

+ assert_equals(getComputedStyle(children[OverflowMenuButtons.CLOSED_CAPTIONS]).display, "none");

});

</script>