Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/LayoutTests/media/overflow-menu.js

Issue 2301823002: Reordering media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/overflow-menu.js
diff --git a/third_party/WebKit/LayoutTests/media/overflow-menu.js b/third_party/WebKit/LayoutTests/media/overflow-menu.js
index 62763659c09136e8d527e69e8ed8ee0ae11f645d..5d914921bd31794ec8f96978225c82c7c94a8315 100644
--- a/third_party/WebKit/LayoutTests/media/overflow-menu.js
+++ b/third_party/WebKit/LayoutTests/media/overflow-menu.js
@@ -1,11 +1,11 @@
// We expect the items in the overflow to appear in the following ordering.
var overflowButtonsCSS = [
+ "-webkit-media-controls-play-button",
+ "-webkit-media-controls-fullscreen-button",
+ "-internal-download-button",
"-webkit-media-controls-mute-button",
"-internal-media-controls-cast-button",
- "-webkit-media-controls-toggle-closed-captions-button",
- "-webkit-media-controls-fullscreen-button",
- "-webkit-media-controls-play-button",
- "-internal-download-button"];
+ "-webkit-media-controls-toggle-closed-captions-button"];
// PseudoID for the overflow button
var menuID = "-internal-overflow-menu-button";
// PseudoID for the overflow list
@@ -23,14 +23,14 @@ function getOverflowList(media) {
// Location of media control element in the overflow button
var OverflowMenuButtons = {
- MUTE: 0,
- CAST: 1,
- CLOSED_CAPTIONS: 2,
- FULLSCREEN: 3,
- PLAY: 4,
- DOWNLOAD: 5,
+ PLAY: 0,
+ FULLSCREEN: 1,
+ DOWNLOAD: 2,
+ MUTE: 3,
+ CAST: 4,
+ CLOSED_CAPTIONS: 5,
};
// Default text within the overflow menu
-var overflowMenuText = ["Mute", "Cast", "Captions", "Fullscreen", "Play", "Download"];
+var overflowMenuText = ["Play", "Fullscreen", "Download", "Mute", "Cast", "Captions"];

Powered by Google App Engine
This is Rietveld 408576698