Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java

Issue 2301823002: Reordering media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/controls-cast-button.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
index a573fcb55303b6a4efa090066275b98e26f6822e..80dddc050292c263df72bc31acf553388d8d27ba 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
@@ -535,7 +535,7 @@ public abstract class CastTestBase extends ChromeActivityTestCaseBase<ChromeActi
return new Rect(left, bar.top, right, bar.bottom);
}
- private Rect downloadButton(Rect videoRect) {
+ private Rect castButton(Rect videoRect) {
Rect bar = controlBar(videoRect);
int right = bar.right - BUTTON_RIGHT_MARGIN;
int left = right - BUTTON_WIDTH;
@@ -549,11 +549,11 @@ public abstract class CastTestBase extends ChromeActivityTestCaseBase<ChromeActi
return new Rect(left, downloadButton.top, right, downloadButton.bottom);
}
- private Rect castButton(Rect videoRect) {
- Rect fullscreenButton = fullscreenButton(videoRect);
- int right = fullscreenButton.left;
+ private Rect downloadButton(Rect videoRect) {
+ Rect castButton = castButton(videoRect);
+ int right = castButton.right - BUTTON_RIGHT_MARGIN;
int left = right - BUTTON_WIDTH;
- return new Rect(left, fullscreenButton.top, right, fullscreenButton.bottom);
+ return new Rect(left, castButton.top, right, castButton.bottom);
}
private void tapButton(Tab tab, Rect rect) {
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/controls-cast-button.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698