Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java

Issue 2301823002: Reordering media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls
Patch Set: fixing android tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
index a573fcb55303b6a4efa090066275b98e26f6822e..50ec51072227903fce60dd974a56783f24360c70 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
@@ -535,7 +535,7 @@ public abstract class CastTestBase extends ChromeActivityTestCaseBase<ChromeActi
return new Rect(left, bar.top, right, bar.bottom);
}
- private Rect downloadButton(Rect videoRect) {
+ private Rect castButton(Rect videoRect) {
Rect bar = controlBar(videoRect);
int right = bar.right - BUTTON_RIGHT_MARGIN;
int left = right - BUTTON_WIDTH;
@@ -549,7 +549,7 @@ public abstract class CastTestBase extends ChromeActivityTestCaseBase<ChromeActi
return new Rect(left, downloadButton.top, right, downloadButton.bottom);
}
- private Rect castButton(Rect videoRect) {
+ private Rect downloadButton(Rect videoRect) {
Rect fullscreenButton = fullscreenButton(videoRect);
whywhat 2016/09/16 14:18:55 hm, isn't this a unending recursion now? you call
kdsilva 2016/09/16 15:25:03 Whoops. Fixed.
int right = fullscreenButton.left;
int left = right - BUTTON_WIDTH;

Powered by Google App Engine
This is Rietveld 408576698