third_party/WebKit/LayoutTests/media/video-controls-track-selection-menu.html - Issue 2301823002: Reordering media controls.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-track-selection-menu.html

Issue 2301823002: Reordering media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-controls

Patch Set: fixing android tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java ('K') | « third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Test that we can display a track list menu and select tracks from the lis t.</title>	2 <title>Test that we can display a track list menu and select tracks from the lis t.</title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="track/track-helpers.js"></script>	5 <script src="track/track-helpers.js"></script>

6 <script src="media-file.js"></script>	6 <script src="media-file.js"></script>

7 <script src="media-controls.js"></script>	7 <script src="media-controls.js"></script>

8 <video controls>	8 <video controls style="width: 500px">
	whywhat 2016/09/16 14:18:55 nit: comment. nit: comment. kdsilva 2016/09/16 15:25:03 Done. Show quoted text On 2016/09/16 14:18:55, whywhat wrote: > nit: comment. Done.
9 <track src="track/captions-webvtt/captions.vtt" kind="captions" label="Track 1">	9 <track src="track/captions-webvtt/captions.vtt" kind="captions" label="Track 1">

10 <track src="track/captions-webvtt/long-word.vtt" kind="captions" label="Trac k2">	10 <track src="track/captions-webvtt/long-word.vtt" kind="captions" label="Trac k2">

11 </video>	11 </video>

12 <script>	12 <script>

13 async_test(function(t) {	13 async_test(function(t) {

14 var video = document.querySelector("video");	14 var video = document.querySelector("video");

15	15

16 var trackElements = document.querySelectorAll("track");	16 var trackElements = document.querySelectorAll("track");

17 for (var i = 0; i < video.textTracks.length; i++)	17 for (var i = 0; i < video.textTracks.length; i++)

18 trackElements[i].onload = t.step_func(trackLoaded);	18 trackElements[i].onload = t.step_func(trackLoaded);

(...skipping 21 matching lines...) Expand all Loading...
40 // Select track 1 and verify it is displayed.	40 // Select track 1 and verify it is displayed.

41 clickTextTrackAtIndex(video, 1);	41 clickTextTrackAtIndex(video, 1);

42 assert_equals(video.textTracks[0].mode, "disabled");	42 assert_equals(video.textTracks[0].mode, "disabled");

43 assert_equals(video.textTracks[1].mode, "showing");	43 assert_equals(video.textTracks[1].mode, "showing");

44 assert_equals(textTrackDisplayElement(video).innerText, "first capti on");	44 assert_equals(textTrackDisplayElement(video).innerText, "first capti on");

45 });	45 });

46	46

47 video.src = findMediaFile("video", "content/test");	47 video.src = findMediaFile("video", "content/test");

48 }	48 }

49 });	49 });

50 </script>	50 </script>

OLD	NEW