android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 23018005: Start renderer in ContentViewCoreImpl::EvaluateJavaScript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 23018005: Start renderer in ContentViewCoreImpl::EvaluateJavaScript. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index ffb5eb4adaf6637a7b114066c780cd9898c380ee..0690b0ae2ebcb788011f5b3436aa943773638374 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -1365,7 +1365,8 @@ public class AwContents {

}

/**

- * @see ContentViewCore.evaluateJavaScript(String, ContentViewCOre.JavaScriptCallback)

+ * @see ContentViewCore.evaluateJavaScriptEvenIfNotYetNavigated(

+ * String, ContentViewCore.JavaScriptCallback)

public void evaluateJavaScript(String script, final ValueCallback<String> callback) {

ContentViewCore.JavaScriptCallback jsCallback = null;

@@ -1378,7 +1379,7 @@ public class AwContents {

};

}

- mContentViewCore.evaluateJavaScript(script, jsCallback);

+ mContentViewCore.evaluateJavaScriptEvenIfNotYetNavigated(script, jsCallback);

}

//--------------------------------------------------------------------------------------------

« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.h » ('j') | content/browser/android/content_view_core_impl.cc » ('J')