Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2301793002: Add a test case for mouse hover on annotation with empty content. (Closed)

Created:
4 years, 3 months ago by jaepark
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a test case for mouse hover on annotation with empty content. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/6608bf041de1104595d3e9c0c18cd411d4757446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + pdfium/annots/annotation_highlight_empty_content.evt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pdfium/annots/annotation_highlight_empty_content.pdf View Binary file 0 comments Download
A + pdfium/annots/annotation_highlight_empty_content_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 5 (2 generated)
jaepark
Popup window should not be displayed if the annotation has empty content string. This is ...
4 years, 3 months ago (2016-09-01 01:08:24 UTC) #2
dsinclair
lgtm
4 years, 3 months ago (2016-09-01 14:17:43 UTC) #3
jaepark
4 years, 3 months ago (2016-09-08 18:54:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6608bf041de1104595d3e9c0c18cd411d4757446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698