Issue 2301783002: Revert of Fix gn gn --check complaints about fxcrt.

Issue 2301783002: Revert of Fix gn gn --check complaints about fxcrt. (Closed)

Created:
4 years, 3 months ago by Lei Zhang

Modified:
4 years, 3 months ago

Reviewers:
Dirk Pranke, dsinclair

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Revert of Fix gn gn --check complaints about fxcrt. (patchset #1 id:1 of https://codereview.chromium.org/2289263005/ ) Reason for revert: Breaking non-standalone builds. Original issue's description: > Fix gn gn --check complaints about fxcrt. > > Committed: https://pdfium.googlesource.com/pdfium/+/6f9ae19b9b125af868077f4eee80a13e0c29c61e TBR=dpranke@chromium.org,dsinclair@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/380f53ec1d0a46648473e407934c9adede6cc1bd

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -78 lines)			Patch
	M	BUILD.gn	View		19 chunks	+33 lines, -72 lines	0 comments	Download
	M	third_party/BUILD.gn	View		2 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Lei Zhang

Created Revert of Fix gn gn --check complaints about fxcrt.

4 years, 3 months ago (2016-09-01 01:01:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301783002/1

4 years, 3 months ago (2016-09-01 01:01:42 UTC) #3

commit-bot: I haz the power

4 years, 3 months ago (2016-09-01 01:01:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/380f53ec1d0a46648473e407934c9adede6c...