Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: src/interpreter/interpreter.cc

Issue 2301743002: [Tracing] Re-add trace-events used by metrics accidentally removed. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/interpreter.h" 5 #include "src/interpreter/interpreter.h"
6 6
7 #include <fstream> 7 #include <fstream>
8 #include <memory> 8 #include <memory>
9 9
10 #include "src/ast/prettyprinter.h" 10 #include "src/ast/prettyprinter.h"
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 173
174 return SUCCEEDED; 174 return SUCCEEDED;
175 } 175 }
176 176
177 InterpreterCompilationJob::Status InterpreterCompilationJob::ExecuteJobImpl() { 177 InterpreterCompilationJob::Status InterpreterCompilationJob::ExecuteJobImpl() {
178 // TODO(5203): These timers aren't thread safe, move to using the CompilerJob 178 // TODO(5203): These timers aren't thread safe, move to using the CompilerJob
179 // timers. 179 // timers.
180 RuntimeCallTimerScope runtimeTimer(info()->isolate(), 180 RuntimeCallTimerScope runtimeTimer(info()->isolate(),
181 &RuntimeCallStats::CompileIgnition); 181 &RuntimeCallStats::CompileIgnition);
182 TimerEventScope<TimerEventCompileIgnition> timer(info()->isolate()); 182 TimerEventScope<TimerEventCompileIgnition> timer(info()->isolate());
183 TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"), "V8.CompileIgnition");
183 TRACE_EVENT_RUNTIME_CALL_STATS_TRACING_SCOPED( 184 TRACE_EVENT_RUNTIME_CALL_STATS_TRACING_SCOPED(
184 info()->isolate(), &tracing::TraceEventStatsTable::CompileIgnition); 185 info()->isolate(), &tracing::TraceEventStatsTable::CompileIgnition);
185 186
186 generator()->GenerateBytecode(stack_limit()); 187 generator()->GenerateBytecode(stack_limit());
187 188
188 if (generator()->HasStackOverflow()) { 189 if (generator()->HasStackOverflow()) {
189 return FAILED; 190 return FAILED;
190 } 191 }
191 return SUCCEEDED; 192 return SUCCEEDED;
192 } 193 }
(...skipping 2193 matching lines...) Expand 10 before | Expand all | Expand 10 after
2386 __ StoreObjectField(generator, JSGeneratorObject::kContinuationOffset, 2387 __ StoreObjectField(generator, JSGeneratorObject::kContinuationOffset,
2387 __ SmiTag(new_state)); 2388 __ SmiTag(new_state));
2388 __ SetAccumulator(old_state); 2389 __ SetAccumulator(old_state);
2389 2390
2390 __ Dispatch(); 2391 __ Dispatch();
2391 } 2392 }
2392 2393
2393 } // namespace interpreter 2394 } // namespace interpreter
2394 } // namespace internal 2395 } // namespace internal
2395 } // namespace v8 2396 } // namespace v8
OLDNEW
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698