Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2301743002: [Tracing] Re-add trace-events used by metrics accidentally removed. (Closed)

Created:
4 years, 3 months ago by lpy
Modified:
4 years, 3 months ago
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Tracing] Re-add trace-events used by metrics accidentally removed. We removed some TRACE_EVENT0 instrumentation when we landed runtime call stats tracing, however some of them are used in metrics, this patch adds these TRACE_EVENT0 back. BUG=642373 LOG=N Committed: https://crrev.com/7a7c0ec5af8092dabbbcd89d7427d7636e074f25 Cr-Commit-Position: refs/heads/master@{#39104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/compiler.cc View 10 chunks +16 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
lpy
PTAL.
4 years, 3 months ago (2016-08-31 23:47:01 UTC) #4
fmeawad
LGTM Make the title more descriptive like. "[Tracing] Re-add trace-events used by metrics accidentally removed"
4 years, 3 months ago (2016-08-31 23:52:43 UTC) #5
lpy
Thanks. + jochen@, ptal.
4 years, 3 months ago (2016-09-01 00:06:40 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-01 12:14:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301743002/1
4 years, 3 months ago (2016-09-01 15:18:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23084)
4 years, 3 months ago (2016-09-01 15:22:21 UTC) #15
lpy
+ bmeurer@ for full-codegen/ and ignition. + adamk@ for parsing/
4 years, 3 months ago (2016-09-01 15:58:59 UTC) #17
adamk
lgtm
4 years, 3 months ago (2016-09-01 17:18:50 UTC) #18
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-01 18:42:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301743002/1
4 years, 3 months ago (2016-09-01 19:15:13 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 20:07:38 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:08:48 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a7c0ec5af8092dabbbcd89d7427d7636e074f25
Cr-Commit-Position: refs/heads/master@{#39104}

Powered by Google App Engine
This is Rietveld 408576698