Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2301733002: fast-startup: do not emit inherit calls for classes from different fragments (Closed)

Created:
4 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 3 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fast-startup: do not emit inherit calls for classes from different fragments R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/f3d33426588c290cf538f7e8229f3c460195bde1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +8 lines, -1 line 0 comments Download
A tests/compiler/dart2js_extra/deferred_inheritance_lib1.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/compiler/dart2js_extra/deferred_inheritance_lib2.dart View 1 chunk +1 line, -0 lines 0 comments Download
A tests/compiler/dart2js_extra/deferred_inheritance_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Siggi Cherem (dart-lang)
4 years, 3 months ago (2016-08-31 23:49:22 UTC) #3
sra1
lgtm
4 years, 3 months ago (2016-09-01 15:22:49 UTC) #4
Siggi Cherem (dart-lang)
4 years, 3 months ago (2016-09-01 16:40:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
f3d33426588c290cf538f7e8229f3c460195bde1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698