Fix for ASSERT and more with bad CSS input.

Fix for Assert and more with bad CSS input.

The CSS input had a strange belief that users are nice and would not
feed it strange strings. This caused asserts and bug 360403.

BUG=360403
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171169

[Daniel Bratell, 2014-04-09 13:28:52]

jchaffraix and eseidel, you looked at similar bug a week ago, could you take a
look at this fix as well?

It fixes the problem that checkEscapedString could bail early, so the calling
code could miscalculate how long the whole string is.

[eseidel, 2014-04-09 17:47:31]

https://codereview.chromium.org/230173005/diff/1/Source/core/css/CSSTokenizer...
File Source/core/css/CSSTokenizer-in.cpp (right):

https://codereview.chromium.org/230173005/diff/1/Source/core/css/CSSTokenizer...
Source/core/css/CSSTokenizer-in.cpp:357: static inline CharacterType*
checkAndSkipString(CharacterType* currentCharacter, int quote, bool validate)
Please use an enum instead of a bool.

enum ValidateBehavior {
   ValidateString,
   DoNotValidateString,
}

You can probably come up with better names than that.  I'm still not sure what
those mean, but at least they would make teh callsites more readable than
"true", "false".

[Daniel Bratell, 2014-04-09 18:07:38]

https://codereview.chromium.org/230173005/diff/1/Source/core/css/CSSTokenizer...
File Source/core/css/CSSTokenizer-in.cpp (right):

https://codereview.chromium.org/230173005/diff/1/Source/core/css/CSSTokenizer...
Source/core/css/CSSTokenizer-in.cpp:357: static inline CharacterType*
checkAndSkipString(CharacterType* currentCharacter, int quote, bool validate)
On 2014/04/09 17:47:32, eseidel wrote:
> Please use an enum instead of a bool.
> 
> enum ValidateBehavior {
>    ValidateString,
>    DoNotValidateString,
> }
> 
> You can probably come up with better names than that.  I'm still not sure what
> those mean, but at least they would make teh callsites more readable than
> "true", "false".

Done.

[eseidel, 2014-04-09 18:09:04]

lgtm

Muuuuuch better.

[commit-bot: I haz the power, 2014-04-09 18:09:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bratell@opera.com/230173005/20001

[commit-bot: I haz the power, 2014-04-09 19:17:47]

Change committed as 171169