Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: extensions/browser/file_reader_unittest.cc

Issue 2301713002: Remove some UI->FILE->UI thread hops in ExecuteCodeFunction (Closed)
Patch Set: git cl format Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« extensions/browser/file_reader.cc ('K') | « extensions/browser/file_reader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/file_reader_unittest.cc
diff --git a/extensions/browser/file_reader_unittest.cc b/extensions/browser/file_reader_unittest.cc
index 37caa01b8f90d258390e828503c2ddb087cf4e27..346c87d32f527280cdce54422fbc938a61519a0b 100644
--- a/extensions/browser/file_reader_unittest.cc
+++ b/extensions/browser/file_reader_unittest.cc
@@ -35,7 +35,7 @@ class Receiver {
Receiver() : succeeded_(false) {
}
- FileReader::Callback NewCallback() {
+ FileReader::DoneCallback NewCallback() {
return base::Bind(&Receiver::DidReadFile, base::Unretained(this));
}
@@ -67,7 +67,8 @@ void RunBasicTest(const char* filename) {
Receiver receiver;
scoped_refptr<FileReader> file_reader(
- new FileReader(resource, receiver.NewCallback()));
+ new FileReader(resource, FileReader::OptionalFileThreadTaskCallback(),
+ receiver.NewCallback()));
file_reader->Start();
base::RunLoop().Run();
@@ -95,7 +96,8 @@ TEST_F(FileReaderTest, NonExistantFile) {
Receiver receiver;
scoped_refptr<FileReader> file_reader(
- new FileReader(resource, receiver.NewCallback()));
+ new FileReader(resource, FileReader::OptionalFileThreadTaskCallback(),
+ receiver.NewCallback()));
file_reader->Start();
base::RunLoop().Run();
« extensions/browser/file_reader.cc ('K') | « extensions/browser/file_reader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698