Remove some UI->FILE->UI thread hops in ExecuteCodeFunction

extensions/browser/api/execute_code_function.h

Index: extensions/browser/api/execute_code_function.h
diff --git a/extensions/browser/api/execute_code_function.h b/extensions/browser/api/execute_code_function.h
index 3ba96e21317feb317c80eedc95e299434b9f52dd..082d5c7499285322fade3b86607051139866af8c 100644
--- a/extensions/browser/api/execute_code_function.h
+++ b/extensions/browser/api/execute_code_function.h
@@ -52,17 +52,24 @@ class ExecuteCodeFunction : public AsyncExtensionFunction {
   std::unique_ptr<api::extension_types::InjectDetails> details_;
 
  private:
-  // Called when contents from the file whose path is specified in JSON
-  // arguments has been loaded.
-  void DidLoadFile(bool success, std::unique_ptr<std::string> data);
-
-  // Runs on FILE thread. Loads message bundles for the extension and
-  // localizes the CSS data. Calls back DidLoadAndLocalizeFile on the UI thread.
-  void GetFileURLAndLocalizeCSS(ScriptExecutor::ScriptType script_type,
-                                std::unique_ptr<std::string> data,
-                                const std::string& extension_id,
-                                const base::FilePath& extension_path,
-                                const std::string& extension_default_locale);
+  // Retrieves GURL from filepath and optionally localizes |data|.

[Devlin, 2016/09/01 04:21:25]

nitty nits: Retrieves the file url for the given |extension_path|...

[lazyboy, 2016/09/01 05:52:58]

Done.

+  // Localization depends on whether |requires_localization| was specified. Only
+  // CSS file content needs to be localized.
+  // Runs on FILE thread.
+  void GetFileURLAndMaybeLocalize(const std::string& extension_id,

[Devlin, 2016/09/01 04:21:25]

optional nit: Since we're renaming all these, I find it much more clear when the
method itself has the loop if it's unclear, e.g.
GetFileUrlAndMaybeLocalizeOnFileThread.

It's a mouthful, but if it saves me needing to read the comment in the header,
it might save time overall.

[lazyboy, 2016/09/01 05:52:58]

Done.

+                                  const base::FilePath& extension_path,
+                                  const std::string& extension_default_locale,
+                                  bool requires_localization,
+                                  bool success,
+                                  std::string* data);
+
+  // Runs on FILE thread.
+  void GetFileURLAndLocalizeComponentResource(
+      std::unique_ptr<std::string> data,
+      bool requires_localization,
+      const std::string& extension_id,
+      const base::FilePath& extension_path,
+      const std::string& extension_default_locale);
 
   // Run in UI thread.  Code string contains the code to be executed. Returns
   // true on success. If true is returned, this does an AddRef.