Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: extensions/browser/api/execute_code_function.h

Issue 2301713002: Remove some UI->FILE->UI thread hops in ExecuteCodeFunction (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/execute_code_function.h
diff --git a/extensions/browser/api/execute_code_function.h b/extensions/browser/api/execute_code_function.h
index 3ba96e21317feb317c80eedc95e299434b9f52dd..7c3107ea5d2c00ecd5113d0781ffb4ce2000932a 100644
--- a/extensions/browser/api/execute_code_function.h
+++ b/extensions/browser/api/execute_code_function.h
@@ -54,15 +54,19 @@ class ExecuteCodeFunction : public AsyncExtensionFunction {
private:
// Called when contents from the file whose path is specified in JSON
// arguments has been loaded.
- void DidLoadFile(bool success, std::unique_ptr<std::string> data);
+ void DidLoadFile(bool success,
+ const GURL& file_url,
+ std::unique_ptr<std::string> data);
+
+ // Runs on FILE thread.
+ void GetFileURL(std::unique_ptr<std::string> data);
// Runs on FILE thread. Loads message bundles for the extension and
// localizes the CSS data. Calls back DidLoadAndLocalizeFile on the UI thread.
- void GetFileURLAndLocalizeCSS(ScriptExecutor::ScriptType script_type,
- std::unique_ptr<std::string> data,
- const std::string& extension_id,
- const base::FilePath& extension_path,
- const std::string& extension_default_locale);
+ void LocalizeCSS(std::unique_ptr<std::string> data,
+ const std::string& extension_id,
+ const base::FilePath& extension_path,
+ const std::string& extension_default_locale);
// Run in UI thread. Code string contains the code to be executed. Returns
// true on success. If true is returned, this does an AddRef.
« no previous file with comments | « no previous file | extensions/browser/api/execute_code_function.cc » ('j') | extensions/browser/api/execute_code_function.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698