Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: extensions/browser/file_reader.h

Issue 2301713002: Remove some UI->FILE->UI thread hops in ExecuteCodeFunction (Closed)
Patch Set: sync, move changes from accessibility_manager.cc -> accessibility_extension_loader.cc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/api/execute_code_function.cc ('k') | extensions/browser/file_reader.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_FILE_READER_H_ 5 #ifndef EXTENSIONS_BROWSER_FILE_READER_H_
6 #define EXTENSIONS_BROWSER_FILE_READER_H_ 6 #define EXTENSIONS_BROWSER_FILE_READER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/single_thread_task_runner.h" 12 #include "base/single_thread_task_runner.h"
13 #include "extensions/common/extension_resource.h" 13 #include "extensions/common/extension_resource.h"
14 14
15 // This file defines an interface for reading a file asynchronously on a 15 // This file defines an interface for reading a file asynchronously on a
16 // background thread. 16 // background thread.
17 // Consider abstracting out a FilePathProvider (ExtensionResource) and moving 17 // Consider abstracting out a FilePathProvider (ExtensionResource) and moving
18 // back to chrome/browser/net if other subsystems want to use it. 18 // back to chrome/browser/net if other subsystems want to use it.
19 class FileReader : public base::RefCountedThreadSafe<FileReader> { 19 class FileReader : public base::RefCountedThreadSafe<FileReader> {
20 public: 20 public:
21 // Reports success or failure and the data of the file upon success. 21 // Reports success or failure and the data of the file upon success.
22 typedef base::Callback<void(bool, std::unique_ptr<std::string>)> Callback; 22 using DoneCallback = base::Callback<void(bool, std::unique_ptr<std::string>)>;
23 // Lets the caller accomplish tasks on the file data, after the file content
24 // has been read.
25 // If the file reading doesn't succeed, this will be ignored.
26 using OptionalFileThreadTaskCallback = base::Callback<void(std::string*)>;
23 27
24 FileReader(const extensions::ExtensionResource& resource, 28 FileReader(const extensions::ExtensionResource& resource,
25 const Callback& callback); 29 const OptionalFileThreadTaskCallback& file_thread_task_callback,
30 const DoneCallback& done_callback);
26 31
27 // Called to start reading the file on a background thread. Upon completion, 32 // Called to start reading the file on a background thread. Upon completion,
28 // the callback will be notified of the results. 33 // the callback will be notified of the results.
29 void Start(); 34 void Start();
30 35
31 private: 36 private:
32 friend class base::RefCountedThreadSafe<FileReader>; 37 friend class base::RefCountedThreadSafe<FileReader>;
33 38
34 virtual ~FileReader(); 39 virtual ~FileReader();
35 40
36 void ReadFileOnBackgroundThread(); 41 void ReadFileOnBackgroundThread();
37 42
38 extensions::ExtensionResource resource_; 43 extensions::ExtensionResource resource_;
39 Callback callback_; 44 OptionalFileThreadTaskCallback optional_file_thread_task_callback_;
45 DoneCallback done_callback_;
40 const scoped_refptr<base::SingleThreadTaskRunner> origin_task_runner_; 46 const scoped_refptr<base::SingleThreadTaskRunner> origin_task_runner_;
41 }; 47 };
42 48
43 #endif // EXTENSIONS_BROWSER_FILE_READER_H_ 49 #endif // EXTENSIONS_BROWSER_FILE_READER_H_
OLDNEW
« no previous file with comments | « extensions/browser/api/execute_code_function.cc ('k') | extensions/browser/file_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698