Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: extensions/browser/file_reader.h

Issue 2301713002: Remove some UI->FILE->UI thread hops in ExecuteCodeFunction (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_FILE_READER_H_ 5 #ifndef EXTENSIONS_BROWSER_FILE_READER_H_
6 #define EXTENSIONS_BROWSER_FILE_READER_H_ 6 #define EXTENSIONS_BROWSER_FILE_READER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/single_thread_task_runner.h" 12 #include "base/single_thread_task_runner.h"
13 #include "extensions/common/extension_resource.h" 13 #include "extensions/common/extension_resource.h"
14 14
15 class GURL;
16
15 // This file defines an interface for reading a file asynchronously on a 17 // This file defines an interface for reading a file asynchronously on a
16 // background thread. 18 // background thread.
17 // Consider abstracting out a FilePathProvider (ExtensionResource) and moving 19 // Consider abstracting out a FilePathProvider (ExtensionResource) and moving
18 // back to chrome/browser/net if other subsystems want to use it. 20 // back to chrome/browser/net if other subsystems want to use it.
19 class FileReader : public base::RefCountedThreadSafe<FileReader> { 21 class FileReader : public base::RefCountedThreadSafe<FileReader> {
20 public: 22 public:
21 // Reports success or failure and the data of the file upon success. 23 // Reports success or failure and the data of the file upon success.
22 typedef base::Callback<void(bool, std::unique_ptr<std::string>)> Callback; 24 typedef base::Callback<
25 void(bool, const GURL& file_url, std::unique_ptr<std::string>)>
26 Callback;
23 27
24 FileReader(const extensions::ExtensionResource& resource, 28 FileReader(const extensions::ExtensionResource& resource,
25 const Callback& callback); 29 const Callback& callback);
26 30
27 // Called to start reading the file on a background thread. Upon completion, 31 // Called to start reading the file on a background thread. Upon completion,
28 // the callback will be notified of the results. 32 // the callback will be notified of the results.
29 void Start(); 33 void Start();
30 34
31 private: 35 private:
32 friend class base::RefCountedThreadSafe<FileReader>; 36 friend class base::RefCountedThreadSafe<FileReader>;
33 37
34 virtual ~FileReader(); 38 virtual ~FileReader();
35 39
36 void ReadFileOnBackgroundThread(); 40 void ReadFileOnBackgroundThread();
37 41
38 extensions::ExtensionResource resource_; 42 extensions::ExtensionResource resource_;
39 Callback callback_; 43 Callback callback_;
40 const scoped_refptr<base::SingleThreadTaskRunner> origin_task_runner_; 44 const scoped_refptr<base::SingleThreadTaskRunner> origin_task_runner_;
41 }; 45 };
42 46
43 #endif // EXTENSIONS_BROWSER_FILE_READER_H_ 47 #endif // EXTENSIONS_BROWSER_FILE_READER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698