Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2301703002: [Offline Pages] Adds UMA for number of started attempts and for network connection when Unsupported… (Closed)
Patch Set: Adjusted count histogram max arg Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index 881f5648b0df17db3ae8c5ed51040f66170fb005..5b816f77d524fe852ae532373be16fa493e1e48a 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -211,6 +211,15 @@ class RequestCoordinator : public KeyedService,
// If there is an active request in the list, cancel that request.
bool CancelActiveRequestIfItMatches(const std::vector<int64_t>& request_ids);
+ // Records an aborted attempt for the request and update it in the queue
+ // (possibly removing it). Returns the updated copy.
+ void AbortRequestAttempt(SavePageRequest* request);
+
+ // Remove the attempted request from the queue with status to pass through to
+ // any observers and UMA histogram.
+ void RemoveAttemptedRequest(const SavePageRequest& request,
+ SavePageStatus status);
+
// Returns the appropriate offliner to use, getting a new one from the factory
// if needed.
void GetOffliner();
« no previous file with comments | « components/offline_pages/background/offliner_policy.h ('k') | components/offline_pages/background/request_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698